Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename $module to $root across the project #5322

Closed
1 task
Tracked by #5292
romaricpascal opened this issue Sep 16, 2024 · 2 comments · Fixed by #5337
Closed
1 task
Tracked by #5292

Rename $module to $root across the project #5322

romaricpascal opened this issue Sep 16, 2024 · 2 comments · Fixed by #5337
Assignees

Comments

@romaricpascal
Copy link
Member

romaricpascal commented Sep 16, 2024

What

Rename $module storing the component's root to $root across the project.

Why

The historic $module name can cause confusion with what a module is in JavaScript

Who needs to work on this

Developers

Who needs to review this

Developers

Done when

  • $module has been renamed to $root across the project when representing the element a component is instantiated on.
@romaricpascal
Copy link
Member Author

Work is done in the public-js-api branch, but will need a double check after mergin on main.

@romaricpascal
Copy link
Member Author

After the merge of public-js-api, all references to $module have been renamed to $root so this can be closed 🥳

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Ready to release 🚀
Development

Successfully merging a pull request may close this issue.

1 participant