Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jQuery dependency #105

Open
richard-viney opened this issue Apr 15, 2019 · 5 comments
Open

jQuery dependency #105

richard-viney opened this issue Apr 15, 2019 · 5 comments

Comments

@richard-viney
Copy link
Contributor

Hi,

Right now this addon needs Ember's jQuery integration to be enabled as it uses this.$() in several places, as well as some jQuery functions.

This could be refactored to avoid mandating a dependency on jQuery, though in the meantime adding the @ember/jquery package as an explicit dependency might be a good first step.

Thoughts?

@alexander-alvarez
Copy link
Contributor

alexander-alvarez commented Apr 15, 2019

We just need to push this over the finish line #98
I haven't been much help since I have a massive backlog of work and other prioritize right now, I apologize

@richard-viney
Copy link
Contributor Author

Ok no problem, is there a list of what remains to be done?

@fran-worley
Copy link
Contributor

Will also need to bump ember-element-resize-detector to 0.4.0 as the current dependency version also includes jquery.

@fran-worley
Copy link
Contributor

@alexander-alvarez as this is now causing many deprecation errors in ELT is there anything we can do to help push #98 over the finish line and get a version bump on this?

Alternatively we could do a simple refactor to fix the deprecation issues for now - happy to raise a PR for this if you think this will be quicker.

@waissbluth
Copy link

+1 to @fran-worley. Getting rid of the deprecations by explicitly importing jQuery would be great for now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants