Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alsatian calling constructor for non text fixture class #559

Open
hisuwh opened this issue Oct 12, 2019 · 0 comments
Open

Alsatian calling constructor for non text fixture class #559

hisuwh opened this issue Oct 12, 2019 · 0 comments
Labels
Milestone

Comments

@hisuwh
Copy link
Contributor

hisuwh commented Oct 12, 2019

I have a defined a test class and put in a file suffixed .test.ts (which matches the glob pattern passed to Alsatian). I've put it in a file named like this so it's clear its for tests.

However, this results in Alsatian calling the constructor (which results in an unhandled exception as a required argument is not passed).

I can see the offending line is here

There is a comment (here) which says it won't provide a default fixture as of v2.0.0 as the TestFixture decorator is to be made mandatory. I'm on v2.4.0 (and Alsatian is up to v3.0.0) and this functionality is still here.

I'd willing to look into sending a PR but this would obviously be a breaking change so wondering how you want to handle this. Also, I'm not sure of the state of v3 at the moment (hence why I'm still on v2) so not sure where this fix would need to go.

@jamesadarich jamesadarich added this to the 4.0.0 milestone Mar 25, 2020
@jamesadarich jamesadarich modified the milestones: 4.0.0, 5.0.0 Jun 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants