-
-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make extension keyboard accessible #139
Comments
I think it would be simpler to use some kind of ARIA-aware library for that. I’ve played with react-aria hooks for a bit and it works pretty well. The focus is managed correctly and directional arrows are supported too. The only inconvenience is many hooks depend on their own Could you please assign this issue to me? |
That makes sense to me. I think the main goal is to keep the visual appearance and features the same, but I assume that was obvious. I'd want @MattIPv4 input on the use of react-aria. I'm using that for the website too, and I do like it quite a lot, so it would make sense to use it for the extension too imho. |
Where we can, making sure we're using semantic elements and native events would be best, but if there are cases where we can't do that easily, react-aria seems fine. |
Make the extension work with keyboard input:
The text was updated successfully, but these errors were encountered: