Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ion Writer max_container_depth Not Honored #250

Open
almann opened this issue Jun 15, 2021 · 0 comments
Open

Ion Writer max_container_depth Not Honored #250

almann opened this issue Jun 15, 2021 · 0 comments

Comments

@almann
Copy link
Contributor

almann commented Jun 15, 2021

When investigating partiql/partiql-lang-rust#43, I noticed a couple of things. the max_container_depth option:

https://github.com/amzn/ion-c/blob/d63172996beb043cc06f8a626517eac40ea2699d/ionc/include/ionc/ion_writer.h#L66-L69

Is basically never used. Furthermore, the default of 10 can easily be overrun, and probably should be something a bit higher (I'd recommend making it 1024, as the cost is the container stack).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant