Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Combine array and value identifier functions in translation metadata #570

Open
hdwalters opened this issue Nov 9, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@hdwalters
Copy link
Contributor

Is your feature request related to a problem? Please describe.
I needed to create a temporary array and a temporary value, but I didn't realise there was a gen_array_id() function:

let array = format!("__AMBER_ARRAY_{}", meta.gen_value_id());
let line = format!("__AMBER_LINE_{}", meta.gen_value_id());

I therefore ended up with duplicate array names, creating a hard-to-track-down bug.

Describe the solution you'd like
It doesn't make sense to have separate gen_array_id() and gen_value_id() functions; I propose to combine them.

Describe alternatives you've considered
N/A

Additional context
N/A

@hdwalters hdwalters added the enhancement New feature or request label Nov 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant