-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consider using pre-commit.ci
for style checking in CI
#195
Comments
pre-commit.ci
instead for style checking in CI pre-commit.ci
for style checking in CI
pre-commit.ci
for style checking in CI pre-commit.ci
for style checking in CI
Running the pre-commit check also on CI would be great! About the style checks (isort and black), I would just double check about the following:
|
The formatting packages are already constrained in the jaxsim/.pre-commit-config.yaml Line 12 in 5b96fab
and jaxsim/.pre-commit-config.yaml Line 18 in 5b96fab
Do you prefer to have an error raised with the diff or just let the CI format the commited files? |
Nope the pinning looks good. Can we match it with what specified in |
The pre-commit configuration needs an exact tag or commit SHA. Can we stick with the current configuration since it matches: # From pyproject.toml in #193
"black[jupyter] ~= 24.0" ? |
Yes that sounds good, I thought it could handle less strict versioning. |
By using
pre-commit.ci
, we could eliminate the file related to thestyle
CI configuration, e.g. .github/workflows/style.yml and substitute it with something that leverages the already present.pre-commit-config.yml
and the configuration from thepyproject.toml
.This would allow us to add additional checks (see https://github.com/pre-commit/pre-commit-hooks), especially the
check-added-large-files
, which would prevent the user to commit thepixi.lock
pulled fromlfs
, and the others checks already present in the pre-commit configuration.The text was updated successfully, but these errors were encountered: