Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement logic to resolve resources URIs #8

Closed
diegoferigo opened this issue Oct 4, 2022 · 4 comments · Fixed by #20
Closed

Implement logic to resolve resources URIs #8

diegoferigo opened this issue Oct 4, 2022 · 4 comments · Fixed by #20
Assignees

Comments

@diegoferigo
Copy link
Member

SDF files could use different special tags to access resources from the file system without using absolute paths:

There's always been some confusion (at least in my case) to figure out what is the correct environment variable and URI to use. For example, this is what I ended up implementing in gym-ignition-models, and this is the configuration of icub-models.

Furthermore, URDF to SDF conversion could still be affected by gazebosim/sdformat#227, but I didn't try recently if it was fixed.

This being said, we could implement a pretty extensive logic to resolve all the combinations. I already ended up implementing a work around in a downstream library, that could be ported here in rod.

@diegoferigo
Copy link
Member Author

As written in #20 (comment), we should properly understand all the URI combinations and support all of them. That PR only provides an initial support.

@diegoferigo
Copy link
Member Author

diegoferigo commented Aug 31, 2023

The logic included in rod has been extended by @traversaro in https://github.com/ami-iit/resolve-robotics-uri-py. We might add add this new external dependency if we want a more extensive URI support.

@traversaro
Copy link
Contributor

The logic included in rod has been extended by @traversaro in https://github.com/ami-iit/resolve-robotics-uri-py. We might add add this new external dependency if we want a more extensive URI support.

That may be a good idea, so that if we want to add other kind of support, we can do that. Ideally we can also look into supporting fuel or other fancy, start, by lazy loading sdformat python bindings.

@diegoferigo
Copy link
Member Author

Early support was introduced in #20 and finalized in #28. Closing.

@diegoferigo diegoferigo self-assigned this May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants