Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Markers on zero points #76

Open
13 tasks
dev3225 opened this issue Nov 22, 2022 · 1 comment
Open
13 tasks

Markers on zero points #76

dev3225 opened this issue Nov 22, 2022 · 1 comment

Comments

@dev3225
Copy link
Collaborator

dev3225 commented Nov 22, 2022

User story

  1. As a user
  2. I need markers plotted on the signal whenever there is a zero point
  3. So that I can differentiate positive and negative side.

Acceptance criteria

  • Markers plotted exactly at the intersection point to the zero line of each signal(channel).
  • Marker should be visible to the user as a shaded circle.
  • It should be of diameter larger than the thickness of the signal.

Definition of done (DoD)

  • Application compiles successfully
  • Code is documented
  • Feature/Bug/Change is tested by at least one unit or e2e test
  • Tests have been passed without warnings (except "deprecated" warnings)
  • Changes have been reviewed
  • PR has been merged to dev branch
  • New dependencies have been added to bill of materials
  • Software architecture diagram has been updated
  • All acceptance criteria are fulfilled
  • Screenshot is attached to issue

DoD general criteria

  • Feature has been fully implemented
  • Feature has been merged into the mainline
  • All acceptance criteria were met
  • Product owner approved features
  • All tests are passing
  • Developers agreed to release
@dev3225 dev3225 modified the milestone: Sprint 06 (Mid-Release) Nov 22, 2022
@dev3225 dev3225 changed the title Markers Markers on zero points Nov 30, 2022
@sjelodari sjelodari added this to the Sprint 07 milestone Nov 30, 2022
@PhlppKrmr
Copy link
Collaborator

As mentioned in the sprint planning, move logic/implementation to backend and compute zero crossings there (else we might run into major performance issues).

@sjelodari sjelodari modified the milestones: Sprint 07, Sprint 08 Dec 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants