-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: switch storage for better thread safety #181
Conversation
core/src/main/java/com/amplitude/core/utilities/EventsFileManager.kt
Outdated
Show resolved
Hide resolved
core/src/main/java/com/amplitude/core/utilities/EventsFileManager.kt
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@qingzhuozhen overall looks good. See nits/questions. Thanks for adding diagnostics!
core/src/main/java/com/amplitude/core/utilities/EventsFileManager.kt
Outdated
Show resolved
Hide resolved
core/src/main/java/com/amplitude/core/utilities/EventsFileManager.kt
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Look good. Thanks @qingzhuozhen!
# [1.16.0](v1.15.0...v1.16.0) (2024-03-01) ### Features * switch storage for better thread safety ([#181](#181)) ([918d2d5](918d2d5))
🎉 This PR is included in version 1.16.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Summary
Checklist