Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: only take unique error logs and control limit #188

Merged
merged 3 commits into from
Mar 26, 2024
Merged

fix: only take unique error logs and control limit #188

merged 3 commits into from
Mar 26, 2024

Conversation

qingzhuozhen
Copy link
Contributor

Summary

  • only take unique error logs
  • control how many error logs we send each time

Checklist

  • Does your PR title have the correct title format?
  • Does your PR have a breaking change?: no

@qingzhuozhen qingzhuozhen requested a review from izaaz March 26, 2024 20:46
izaaz
izaaz approved these changes Mar 26, 2024
View reviewed changes
Copy link
Collaborator

@izaaz izaaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comment. Rest LGTM. @crleona's questions are interesting. Its worth making sure swift and kotlin behave similarly at least.

@qingzhuozhen qingzhuozhen merged commit cca7d79 into main Mar 26, 2024
2 checks passed
@qingzhuozhen qingzhuozhen deleted the AMP-96433 branch March 26, 2024 22:17
github-actions bot pushed a commit that referenced this pull request Mar 26, 2024
@amplitude-sdk-bot
chore(release): 1.16.4 [skip ci]
1428953 
## [1.16.4](v1.16.3...v1.16.4) (2024-03-26)

### Bug Fixes

* only take unique error logs and control limit ([#188](#188)) ([cca7d79](cca7d79))
@github-actions GitHub Actions
Copy link

🎉 This PR is included in version 1.16.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

@justin-fiedler justin-fiedler mentioned this pull request Mar 27, 2024
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@izaaz izaaz izaaz approved these changes

@crleona crleona crleona approved these changes

@justin-fiedler justin-fiedler Awaiting requested review from justin-fiedler

@yuhao900914 yuhao900914 Awaiting requested review from yuhao900914

@Mercy811 Mercy811 Awaiting requested review from Mercy811

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@qingzhuozhen @crleona @izaaz