Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: session id not set before plugin setup #189

Merged
merged 2 commits into from
Mar 27, 2024

Conversation

justin-fiedler
Copy link
Contributor

@justin-fiedler justin-fiedler commented Mar 27, 2024

Summary

AMP-96567

  • ensure sessionId is set before Plugin.setup is called

Checklist

  • Does your PR title have the correct title format?
  • Does your PR have a breaking change?: No

@justin-fiedler justin-fiedler requested review from a team and Mercy811 March 27, 2024 17:42
Copy link
Contributor

@Mercy811 Mercy811 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you Justin for fixing this and adding the test. LGTM

@justin-fiedler justin-fiedler merged commit 42e4fef into main Mar 27, 2024
3 checks passed
@justin-fiedler justin-fiedler deleted the AMP-96567-session-id-not-set-before-plugin-setup branch March 27, 2024 20:33
github-actions bot pushed a commit that referenced this pull request Mar 27, 2024
## [1.16.5](v1.16.4...v1.16.5) (2024-03-27)

### Bug Fixes

* session id not set before plugin setup ([#189](#189)) ([42e4fef](42e4fef))
Copy link

🎉 This PR is included in version 1.16.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants