fix: fix race condition where an event can be processed before a session gets extended #198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ion gets extended
justin-fiedler
approved these changes
May 30, 2024
github-actions bot
pushed a commit
that referenced
this pull request
May 30, 2024
## [1.16.8](v1.16.7...v1.16.8) (2024-05-30) ### Bug Fixes * fix race condition where an event can be processed before a session gets extended ([#198](#198)) ([c3627d0](c3627d0))
|
🎉 This PR is included in version 1.16.8 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes a race condition where an event gets processed after the app enters the foreground but before amplitude gets to create a new session.
Instead of setting a flag in Amplitude when the app enters foreground, we now treat all events fired before amplitude's foreground event is fired as background events.
Checklist