Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make com.amplitude.android.Amplitude return com.amplitude.core.platform.Timeline #203

Closed
asherepenko opened this issue Jul 2, 2024 · 1 comment

Comments

@asherepenko
Copy link

Right now android's `Amplitude uses android's package Timeline, wich is final and can't be extended:

    override fun createTimeline(): com.amplitude.android.Timeline {
        return Timeline(configuration.sessionId).also { it.amplitude = this }
    }

It either has to be com.amplitude.core.platform.Timeline or com.amplitude.android.Timeline should be open class

Expected Behavior

Current Behavior

Possible Solution

Steps to Reproduce

Environment

  • Unity Plugin Version:
  • Device:
  • Device OS and Version:
@izaaz
Copy link
Collaborator

izaaz commented Jul 11, 2024

@asherepenko - can you please share what you're trying to do by extending the Timeline class? I can check if we can make that class open but wanted to understand the usecase to see if there are other ways the same functionality can be achieved.

@izaaz izaaz closed this as completed Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants