Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Unterminated arrays caused by multi client instances with same name and api key #61

Merged
merged 6 commits into from
Aug 12, 2022

Conversation

bohan-amplitude
Copy link
Contributor

Summary

  • Put mutex to class companion to lock for possible multi instance access
  • Reduce duplicate events requests from same event file
  • Put curFile reference to companion and managed by apiKey
  • Handle invalid events json string: delete file and clean up callback map

Checklist

  • Does your PR title have the correct title format?
  • Does your PR have a breaking change?: no

Copy link
Collaborator

@liuyang1520 liuyang1520 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bohan-amplitude bohan-amplitude merged commit 48d5be2 into amplitude:main Aug 12, 2022
github-actions bot pushed a commit that referenced this pull request Aug 12, 2022
## [1.1.3](v1.1.2...v1.1.3) (2022-08-12)

### Bug Fixes

* Unterminated arrays caused by multi client instances with same name and api key ([#61](#61)) ([48d5be2](48d5be2))
@github-actions
Copy link

🎉 This PR is included in version 1.1.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

@bohan-amplitude bohan-amplitude deleted the AMP-58365 branch August 12, 2022 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants