Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add ampli extra plugin for attaching ingestion metadata information #76

Merged
merged 1 commit into from
Sep 26, 2022
Merged

feat: add ampli extra plugin for attaching ingestion metadata information #76

merged 1 commit into from
Sep 26, 2022

Conversation

liuyang1520
Copy link
Collaborator

Summary

This PR adds a GetAmpliExtrasPlugin as enrichment plugin for retrieving the ampli information from extra field, currently will be used for the ingestion metadata injection.

Checklist

  • Does your PR title have the correct title format?
  • Does your PR have a breaking change?: No

yuhao900914
yuhao900914 approved these changes Sep 26, 2022
View reviewed changes
Copy link
Contributor

@yuhao900914 yuhao900914 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for me.

@liuyang1520 liuyang1520 merged commit a8aa604 into main Sep 26, 2022
@liuyang1520 liuyang1520 deleted the add-ampli-extra-plugin branch September 26, 2022 19:31
github-actions bot pushed a commit that referenced this pull request Sep 27, 2022
@amplitude-sdk-bot
chore(release): 1.4.0 [skip ci]
384a82d 
# [1.4.0](v1.3.2...v1.4.0) (2022-09-27)

### Bug Fixes

* add GetIngestionMetadataPlugin in android.Amplitude ([#77](#77)) ([0c6d6cb](0c6d6cb))

### Features

* add ampli extra plugin for attaching ingestion metadata information ([#76](#76)) ([a8aa604](a8aa604))
@github-actions
Copy link

🎉 This PR is included in version 1.4.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuhao900914 yuhao900914 yuhao900914 approved these changes

@justin-fiedler justin-fiedler justin-fiedler approved these changes

@qingzhuozhen qingzhuozhen Awaiting requested review from qingzhuozhen

Assignees

@yuhao900914 yuhao900914

Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@liuyang1520 @justin-fiedler @yuhao900914