fix: start build() lazily #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
One test (session logic) is failing for some reason (not failed locally). Should be fixed in #89, I believe |
qingzhuozhen
approved these changes
Oct 25, 2022
|
Can you rebase the branch and resolve the conflict here? |
falconandy
force-pushed
the
DXOC-282-NullPointerException
branch
from
4f1c527
to
211227a
Compare
|
@qingzhuozhen |
github-actions bot
pushed a commit
that referenced
this pull request
Oct 28, 2022
## [1.4.8](v1.4.7...v1.4.8) (2022-10-28) ### Bug Fixes * start build() lazily ([#90](#90)) ([d829ba7](d829ba7))
|
🎉 This PR is included in version 1.4.8 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
build()body callsisBuilt.await()(somewhere in nested subcalls). The body was started immediately and can use uninitializedisBuilt. Now the 'build' body is started lazily just afterisBuiltwas initialized.Checklist