-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add privacy manifest for ios 17 #109
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this looks good. Can you please add some documentation that helps users add additional fields as needed. Thanks!
users can track user Id as well by amplitude.setUserId(). To do so, they have to add "User ID" NSPrivacyCollectedDataTypeUserID to NSPrivacyCollectedDataType.
Thanks @justin-fiedler for reviewing. I have another ticket for docs. |
# [1.2.0](v1.1.0...v1.2.0) (2024-02-05) ### Bug Fixes * ensure event data is sandboxed per app for all platforms ([#113](#113)) ([72da9f8](72da9f8)) * should track coarse location by default ([#110](#110)) ([2aab265](2aab265)) ### Features * add privacy manifest for ios 17 ([#109](#109)) ([cf0ca47](cf0ca47))
🎉 This PR is included in version 1.2.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
I think this is just adding 'PrivacyInfo'. Shouldn't it be applied to SPM and CocoaPod too?? |
Summary
https://amplitude.atlassian.net/browse/AMP-78469
iOS 17 requires this privacy manifest to list all data fields tracked. This PR only includes fields that are tracked by default. Customers should add more fields to their app's privacy manifest file if they decide to track more fields using Amplitude SDK. For example, by default the SDK tracks device Id only, but users can track user Id as well by
amplitude.setUserId()
. To do so, they have to add "User ID"NSPrivacyCollectedDataTypeUserID
toNSPrivacyCollectedDataType
.Please note that the definition of tracking is
Fields
Domain
https://api2.amplitude.com/2/httpapi
Checklist