fix: Set inForeground to true after a new session has been started #124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
izaaz
changed the title
izaaz
changed the title
justin-fiedler
approved these changes
Feb 27, 2024
justin-fiedler
approved these changes
Mar 4, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Mar 5, 2024
## [1.3.6](v1.3.5...v1.3.6) (2024-03-05) ### Bug Fixes * Set inForeground to true after a new session has been started ([#124](#124)) ([3780c44](3780c44))
|
🎉 This PR is included in version 1.3.6 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
There's an edge case where we set the inForeground property to true before extending the session. If an event is triggered between this and the start session creating a new session, an old session can get extended.
Fixing this by only setting the inForeground property to true after a new session has been created if needed
Checklist