Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: migrate storage to for better thread safety #129

Merged
merged 18 commits into from
Mar 15, 2024
Merged

feat: migrate storage to for better thread safety #129

merged 18 commits into from
Mar 15, 2024

Conversation

qingzhuozhen
Copy link
Contributor

Summary

  • migrate storage
  • add diagnostics support

Checklist

  • Does your PR title have the correct title format?
  • Does your PR have a breaking change?: no

@qingzhuozhen qingzhuozhen marked this pull request as ready for review March 11, 2024 23:42
justin-fiedler
justin-fiedler reviewed Mar 13, 2024
View reviewed changes
Sources/Amplitude/Events/BaseEvent.swift Outdated Show resolved Hide resolved
Sources/Amplitude/Amplitude.swift Outdated Show resolved Hide resolved
Sources/Amplitude/Utilities/Diagonostics.swift Outdated Show resolved Hide resolved
@qingzhuozhen qingzhuozhen requested a review from izaaz March 14, 2024 17:00
izaaz
izaaz approved these changes Mar 14, 2024
View reviewed changes
Copy link
Collaborator

@izaaz izaaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Minor non blocking comments.

@qingzhuozhen qingzhuozhen merged commit 2bbe919 into main Mar 15, 2024
3 checks passed
@qingzhuozhen qingzhuozhen deleted the AMP-96490 branch March 15, 2024 00:23
github-actions bot pushed a commit that referenced this pull request Mar 15, 2024
@amplitude-sdk-bot
chore(release): 1.4.0 [skip ci]
5d214c4 
# [1.4.0](v1.3.6...v1.4.0) (2024-03-15)

### Bug Fixes

* Don't use idfv as deviceID if disabled. ([#133](#133)) ([76ef012](76ef012))
* Fixes for automatic screen tracking ([#137](#137)) ([55b2ca9](55b2ca9))
* tests on iOS 17 ([#136](#136)) ([04e5d03](04e5d03))

### Features

* migrate storage to for better thread safety ([#129](#129)) ([2bbe919](2bbe919))
@github-actions GitHub Actions
Copy link

🎉 This PR is included in version 1.4.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justin-fiedler justin-fiedler justin-fiedler approved these changes

@izaaz izaaz izaaz approved these changes

@crleona crleona Awaiting requested review from crleona

@liuyang1520 liuyang1520 Awaiting requested review from liuyang1520

@yuhao900914 yuhao900914 Awaiting requested review from yuhao900914

@Mercy811 Mercy811 Awaiting requested review from Mercy811

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@qingzhuozhen @izaaz @justin-fiedler @liuyang1520