Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Use appropriate background task API for app extensions #138

Merged
merged 1 commit into from
Mar 19, 2024
Merged

fix: Use appropriate background task API for app extensions #138

merged 1 commit into from
Mar 19, 2024

Conversation

crleona
Copy link
Collaborator

@crleona crleona commented Mar 19, 2024

Summary

Per the docs for beginBackgroundTask, "To extend the execution time of an app extension, use the performExpiringActivity(withReason:using:) method of ProcessInfo instead."

This should resolve some client issues flushing events from app extensions.

Checklist

  • Does your PR title have the correct title format?
  • Does your PR have a breaking change?: No

justin-fiedler
justin-fiedler approved these changes Mar 19, 2024
View reviewed changes
Copy link
Contributor

@justin-fiedler justin-fiedler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @crleona!

@crleona crleona merged commit 7231bee into main Mar 19, 2024
7 checks passed
@crleona crleona deleted the extension-background-task-api branch March 19, 2024 15:49
github-actions bot pushed a commit that referenced this pull request Mar 22, 2024
@amplitude-sdk-bot
chore(release): 1.4.2 [skip ci]
7711924 
## [1.4.2](v1.4.1...v1.4.2) (2024-03-22)

### Bug Fixes

* better carthage support ([#142](#142)) ([a6f1559](a6f1559))
* Fix compilation on Xcode 14.x ([#141](#141)) ([8eedaab](8eedaab))
* Use appropriate background task API for app extensions ([#138](#138)) ([7231bee](7231bee))
@github-actions GitHub Actions
Copy link

🎉 This PR is included in version 1.4.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justin-fiedler justin-fiedler justin-fiedler approved these changes

@izaaz izaaz Awaiting requested review from izaaz

@yuhao900914 yuhao900914 Awaiting requested review from yuhao900914

@Mercy811 Mercy811 Awaiting requested review from Mercy811

@qingzhuozhen qingzhuozhen Awaiting requested review from qingzhuozhen

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@crleona @justin-fiedler