Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Fix retain cycles in Amplitude so instance will not leak memory #161

Merged
merged 1 commit into from
May 9, 2024
Merged

feat: Fix retain cycles in Amplitude so instance will not leak memory #161

merged 1 commit into from
May 9, 2024

Conversation

crleona
Copy link
Collaborator

@crleona crleona commented May 9, 2024

Summary

Fixes retain cycles internal to the Amplitude object, allowing it to correctly deallocate. (see #44).

We also add a test ensuring that Amplitude will correctly deallocate to prevent this from happening in the future.

Checklist

  • Does your PR title have the correct title format?
  • Does your PR have a breaking change?: No

@crleona crleona requested review from izaaz, justin-fiedler and a team May 9, 2024 18:04
@crleona crleona force-pushed the AMP-76663-fix-retain-cycle branch from 5e9d974 to 15dedf0 Compare May 9, 2024 18:21
@crleona crleona force-pushed the AMP-76663-fix-retain-cycle branch from 15dedf0 to 9514015 Compare May 9, 2024 21:59
@crleona crleona force-pushed the AMP-76663-fix-retain-cycle branch from 9514015 to 5519c4f Compare May 9, 2024 22:08
justin-fiedler
justin-fiedler approved these changes May 9, 2024
View reviewed changes
Copy link
Contributor

@justin-fiedler justin-fiedler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @crleona

Sources/Amplitude/Plugins/NetworkConnectivityCheckerPlugin.swift Show resolved Hide resolved
@crleona crleona force-pushed the AMP-76663-fix-retain-cycle branch from 5519c4f to 4a44832 Compare May 9, 2024 23:03
@crleona crleona merged commit 492d1fd into main May 9, 2024
3 checks passed
@crleona crleona deleted the AMP-76663-fix-retain-cycle branch May 9, 2024 23:53
github-actions bot pushed a commit that referenced this pull request May 10, 2024
@amplitude-sdk-bot
chore(release): 1.5.0 [skip ci]
f446396 
# [1.5.0](v1.4.5...v1.5.0) (2024-05-10)

### Features

* Dispatch operations to internal queue ([#159](#159)) ([83d24f7](83d24f7))
* Fix retain cycles in Amplitude so instance will not leak memory ([#161](#161)) ([492d1fd](492d1fd))
@github-actions GitHub Actions
Copy link

🎉 This PR is included in version 1.5.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justin-fiedler justin-fiedler justin-fiedler approved these changes

@izaaz izaaz izaaz approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@crleona @izaaz @justin-fiedler