Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: resolve compilation issue with watchOS 8.0 #180

Merged
merged 1 commit into from
Jun 12, 2024
Merged

fix: resolve compilation issue with watchOS 8.0 #180

merged 1 commit into from
Jun 12, 2024

Conversation

crleona
Copy link
Collaborator

@crleona crleona commented Jun 11, 2024

Summary

  • Remove unused WKApplication reference
  • Use app lifecycle notifications from WKExtension, not WKApplication, which are supported on WatchOS 18. (These should be equivalent as both notification rawValues are the same).
  • Remove wasBackgrounded check, which did not appear to work properly as we were only tracking didFinishLaunching in the iOS lifecycle monitor.

Checklist

  • Does your PR title have the correct title format?
  • Does your PR have a breaking change?: no

@crleona crleona requested review from yuhao900914 and a team June 11, 2024 21:00
This was referenced Jun 11, 2024
Closed
Closed
@djavan-bertrand
Copy link

Quickly tested on watchOS 8 simulator and watchOS 10 real device: no crash and events are correctly sent. 🎉

@thedavidharris
Copy link
Contributor

Tested as well, good in a single target watch app. Thanks for this!

@crleona crleona merged commit d0b7bff into main Jun 12, 2024
3 checks passed
@crleona crleona deleted the AMP-102077-fix-watchos-support branch June 12, 2024 19:08
github-actions bot pushed a commit that referenced this pull request Jun 12, 2024
@amplitude-sdk-bot
chore(release): 1.6.1 [skip ci]
ea78e75 
## [1.6.1](v1.6.0...v1.6.1) (2024-06-12)

### Bug Fixes

* Add additional diagnostic logging ([#177](#177)) ([e0e47a7](e0e47a7))
* dispatch identify interceptor callbacks on correct queue ([#176](#176)) ([eaf6d16](eaf6d16))
* resolve compilation issue with watchOS 8.0 ([#180](#180)) ([d0b7bff](d0b7bff))
@github-actions GitHub Actions
Copy link

🎉 This PR is included in version 1.6.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justin-fiedler justin-fiedler justin-fiedler approved these changes

@thedavidharris thedavidharris thedavidharris approved these changes

@yuhao900914 yuhao900914 Awaiting requested review from yuhao900914

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@crleona @djavan-bertrand @thedavidharris @justin-fiedler