fix: set offline when receiving certain error responses #212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
izaaz
reviewed
Aug 19, 2024
izaaz
approved these changes
Aug 19, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Aug 23, 2024
## [1.8.1](v1.8.0...v1.8.1) (2024-08-23) ### Bug Fixes * Delete events on an invalid api key response. ([#211](#211)) ([9329a26](9329a26)) * Fix code compatibility issues on Xcode 14.1 ([#213](#213)) ([b2022b6](b2022b6)) * fix pinchGestureRecognizer unavailability issue on tvos ([#217](#217)) ([4c5ae67](4c5ae67)) * set offline when receiving certain error responses ([#212](#212)) ([056ccbf](056ccbf))
|
🎉 This PR is included in version 1.8.1 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When receiving certain connection related failures after a failed url request, set the SDK to offline mode. Any successful NWPathMonitor updates will allow us to reconnect. This prevents us from going in a retry loop.
Checklist