fix: Add maxQueuedEventCount parameter to trim events in storage if over a limit #222
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds a configuration parameter,
maxQueuedEventCount
, intended to control the maximum number of events we store on device. Set to a negative value to have no max count.Every time we initialize Amplitude, we check
maxQueuedEventCount
. If set to a value greater than zero, we will delete all but the most recent maxQueuedEventCount events. Note that we will never attempt to split or otherwise rewrite a block during this process, so we may store an actual max event count ofmaxQueuedEventCount + flushQueueSize - 1
. We also never will clear storage during the lifetime of the Amplitude instance, so more than maxQueuedEventCount events may be queued on the device until the next time Amplitude is run.Checklist