Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: normalize package names for all package managers #69

Merged
merged 3 commits into from
Aug 9, 2023
Merged

fix: normalize package names for all package managers #69

merged 3 commits into from
Aug 9, 2023

Conversation

falconandy
Copy link
Contributor

Summary

Normalize package names for all package managers CocoaPods, Swift Package Manager (SPM), Carthage - now import AmplitudeSwift should be used instead of import Amplitude_Swift

Checklist

  • Does your PR title have the correct title format?
  • Does your PR have a breaking change?: SPM and Carthage users need to update imports.

justin-fiedler
justin-fiedler approved these changes Aug 9, 2023
View reviewed changes
Copy link
Contributor

@justin-fiedler justin-fiedler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @falconandy!

@justin-fiedler justin-fiedler merged commit 251ebdf into main Aug 9, 2023
3 checks passed
@justin-fiedler justin-fiedler deleted the AMP-81996-normalize-package-names-for-package-managers branch August 9, 2023 00:42
github-actions bot pushed a commit that referenced this pull request Aug 9, 2023
@amplitude-sdk-bot
chore(release): 0.4.8 [skip ci]
8c30585 
## [0.4.8](v0.4.7...v0.4.8) (2023-08-09)

### Bug Fixes

* make 'mergeEventOptions' public ([#67](#67)) ([5a946f7](5a946f7))
* normalize package names for all package managers ([#69](#69)) ([251ebdf](251ebdf))
@github-actions
Copy link

github-actions bot commented Aug 9, 2023

🎉 This PR is included in version 0.4.8 🎉

The release is available on:

Your semantic-release bot 📦🚀

yuhao900914
yuhao900914 reviewed Aug 9, 2023
View reviewed changes
Copy link
Contributor

@yuhao900914 yuhao900914 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuhao900914 yuhao900914 yuhao900914 left review comments

@liuyang1520 liuyang1520 liuyang1520 approved these changes

@justin-fiedler justin-fiedler justin-fiedler approved these changes

@bgiori bgiori Awaiting requested review from bgiori

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@falconandy @justin-fiedler @liuyang1520 @yuhao900914