Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove location-related code from SDK, add an example plugin to collect location data #75

Merged
merged 1 commit into from
Aug 15, 2023

Conversation

falconandy
Copy link
Contributor

@falconandy falconandy commented Aug 15, 2023

https://amplitude.atlassian.net/browse/AMP-62860?focusedCommentId=204509

Goal keep Swift SDK interface the same as the other SDKs. Remove locationInfoBlock, provide Plugin example of setting location info instead.

Summary

  1. Removed location-related code from SDK
  2. Add an example plugin to collect location data (simplified ios version of react-native-get-location library)

Checklist

  • Does your PR title have the correct title format?
  • Does your PR have a breaking change?: yes (location-specific code)

Copy link
Contributor

@justin-fiedler justin-fiedler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Thanks @falconandy!

@justin-fiedler justin-fiedler merged commit 34ff8e5 into main Aug 15, 2023
5 checks passed
@justin-fiedler justin-fiedler deleted the AMP-62860-location-plugin branch August 15, 2023 22:15
github-actions bot pushed a commit that referenced this pull request Aug 15, 2023
## [0.4.12](v0.4.11...v0.4.12) (2023-08-15)

### Bug Fixes

* remove location-related code from SDK, add an example plugin to collect location data ([#75](#75)) ([34ff8e5](34ff8e5))
@github-actions
Copy link

🎉 This PR is included in version 0.4.12 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants