fix: Swift UserId and DeviceId setter #299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haoliu-amp
reviewed
Oct 16, 2020
Sources/Amplitude/Amplitude.h
Outdated
| Sets the userId. | ||
| Sets the userId and starts a new session. | ||
|
|
||
| **Note: this is deprecated** - please use `setUserId:(NSString*) userId startNewSession:(BOOL)startNewSession` |
There was a problem hiding this comment.
no space in between for (NSString*) userId
| @@ -87,6 +87,8 @@ @interface Amplitude() | |||
| @property (nonatomic, assign) long long sessionId; | |||
| @property (nonatomic, assign) BOOL backoffUpload; | |||
| @property (nonatomic, assign) int backoffUploadBatchSize; | |||
| @property (nonatomic, copy, readwrite, nullable) NSString *userId; | |||
There was a problem hiding this comment.
This will allow user to call setter without changing readonly for userId and deviceId inside Amplitude.h?
There was a problem hiding this comment.
Changed so readwrite occurs in header instead of implementation
There was a problem hiding this comment.
Will revert so that we can solve the method syntax bug
haoliu-amp
approved these changes
Oct 17, 2020
There was a problem hiding this comment.
@jooohhn You can merge if you verified 2 things-
- Custom setter will be called.
- Setter can both be accessed in objc and swift.
This reverts commit 30c6f02.
github-actions bot
pushed a commit
that referenced
this pull request
Oct 20, 2020
## [7.1.1](v7.1.0...v7.1.1) (2020-10-20) ### Bug Fixes * **buildsettings:** Remove override for GCC_WARN_INHIBIT_ALL_WARNINGS ([#302](#302)) ([0e55297](0e55297)) * **deprecation warnings:** Fix deprecation warnings ([#301](#301)) ([e7b0e6e](e7b0e6e)), closes [/github.com//issues/250#issuecomment-655224554](https://github.com//github.com/amplitude/Amplitude-iOS/issues/250/issues/issuecomment-655224554) * **deprecations:** Use DEPRECATED_MSG_ATTRIBUTE instead of notes ([#305](#305)) ([f501c6c](f501c6c)) * nil dynamic config refresh crash ([#288](#288)) ([#289](#289)) ([9dc896d](9dc896d)) * Swift UserId and DeviceId setter ([#299](#299)) ([b7c0f90](b7c0f90))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Amplitude.mto fix usage in SwiftsetUserId(userId)forsetUserId(userId, startNewSession)Checklist