feat: integrate amplitude core for experiment integration #378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Amplitude.xcodeproj/project.xcworkspace/xcshareddata/IDEWorkspaceChecks.plist
Outdated
Show resolved
Hide resolved
| @@ -37,6 +37,9 @@ jobs: | |||
| run: | | |||
| sudo xcode-select -switch /Applications/Xcode_12.app | |||
|
|
|||
| - name: Carthage Bootstrap | |||
| run: carthage bootstrap --use-xcframeworks | |||
There was a problem hiding this comment.
I guess iOS is not using XC frameworks now, would that be an issue?
There was a problem hiding this comment.
This is for AmplitiudeCore which does use XCFrameworks since each platform supports all architectures which does not work with a regular fat framework. This option tells carthage to build AmplitudeCore into an xcframework rather than just a regular framework.
justin-fiedler
suggested changes
Jan 14, 2022
justin-fiedler
approved these changes
Jan 22, 2022
justin-fiedler
suggested changes
Jan 22, 2022
qingzhuozhen
approved these changes
Feb 4, 2022
justin-fiedler
approved these changes
Feb 4, 2022
|
🎉 This PR is included in version 8.8.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
AmplitudeCoreas a dependency: https://github.com/amplitude/amplitude-ios-coreTODO:
Checklist