fix: update identify collapsing logic to send actions on separate identify event #437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justin-fiedler
requested review from
izaaz,
qingzhuozhen and
ericyang-amplitude
justin-fiedler
suggested changes
Apr 24, 2023
There was a problem hiding this comment.
Thanks @falconandy I think the logic looks right, but had some questions on the event counts in tests.
justin-fiedler
approved these changes
Apr 25, 2023
qingzhuozhen
approved these changes
Apr 25, 2023
justin-fiedler
deleted the
AMP-73588-update-identify-collapsing-logic-to-send-set-actions-on-separate-identify-event
branch
github-actions bot
pushed a commit
that referenced
this pull request
Apr 26, 2023
# [8.16.0](v8.15.2...v8.16.0) (2023-04-26) ### Bug Fixes * update identify collapsing logic to send actions on separate identify event ([#437](#437)) ([9fb64c3](9fb64c3)) * updated identify merging logic to ignore nil values ([#434](#434)) ([8e1239c](8e1239c)) ### Features * update back off for rate limit ([#436](#436)) ([9fc1ba9](9fc1ba9))
|
🎉 This PR is included in version 8.16.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Update identify collapsing logic to send actions on separate identify event.
Added small delays to session tests to make them stable in CI.
Checklist