Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix for when macos sandbox disabled #477

Merged
merged 2 commits into from
Feb 7, 2024
Merged

Conversation

qingzhuozhen
Copy link
Contributor

@qingzhuozhen qingzhuozhen commented Feb 6, 2024

Summary

  • fix for app directory in macos when sandbox is not enabled for app.

When sandboxed, sample path:
/Users/{user}/Library/Containers/com.test.Test/Data/Library/com.amplitude.database
When not sandboxed, sample path:
/Users/{user}/Library/com.amplitude.database.com.test.Test

Checklist

  • Does your PR title have the correct title format?
  • Does your PR have a breaking change?: Only affecting the special case for apps on macos without sandbox enabled.

@qingzhuozhen qingzhuozhen marked this pull request as ready for review February 7, 2024 20:10
Copy link
Contributor

@justin-fiedler justin-fiedler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @qingzhuozhen !

Tests/AMPUtilsTests.m Show resolved Hide resolved
@qingzhuozhen qingzhuozhen merged commit e148734 into main Feb 7, 2024
4 checks passed
@qingzhuozhen qingzhuozhen deleted the fix-macos-sandbox branch February 7, 2024 22:05
github-actions bot pushed a commit that referenced this pull request Feb 7, 2024
# [8.18.0](v8.17.2...v8.18.0) (2024-02-07)

### Bug Fixes

* fix for release pipeline ([#478](#478)) ([324aced](324aced))
* fix for when macos sandbox disabled ([#477](#477)) ([e148734](e148734))

### Features

* add privacy manifest for iOS 17 ([#476](#476)) ([007e169](007e169))
github-actions bot pushed a commit that referenced this pull request Feb 8, 2024
# [8.18.0](v8.17.2...v8.18.0) (2024-02-08)

### Bug Fixes

* fix for release pipeline ([#478](#478)) ([324aced](324aced))
* fix for when macos sandbox disabled ([#477](#477)) ([e148734](e148734))

### Features

* add privacy manifest for iOS 17 ([#476](#476)) ([007e169](007e169))
Copy link

github-actions bot commented Feb 8, 2024

🎉 This PR is included in version 8.18.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants