Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Variant value is missing in some configs on version 1.11.1 #42

Closed
kevinguitar opened this issue Oct 25, 2023 · 3 comments
Closed

Variant value is missing in some configs on version 1.11.1 #42

kevinguitar opened this issue Oct 25, 2023 · 3 comments

Comments

@kevinguitar
Copy link

Hello, after we updated the sdk to the latest version 1.11.1, we started to receive null for some config variants, looks like the expected value is assigned to the key field instead.

For example:

Variant(value=null, payload=null, expKey=null, key=off, metadata={default=true})

Note: The issue is not reproducible on 1.10.1, we'll rollback for now.

@tyiuhc
Copy link
Collaborator

tyiuhc commented Oct 26, 2023

Hi @kevinguitar, many thanks for raising this issue. It seems that evaluation is returning a default variant in this case. To better assist on this issue, it would be helpful if you could let us know:

  1. What variant was expected instead
  2. What configuration (e.g. user_id, device_id) was when evaluation was called
  3. The link to your flag if possible

Please feel free to respond either on this thread, or via email to [email protected].

@kevinguitar
Copy link
Author

@tyiuhc I've emailed all the details to you, thanks for helping!

@tyiuhc
Copy link
Collaborator

tyiuhc commented Nov 1, 2023

For those who are experiencing the same situation:

In pre-1.11 versions, the "fetch()" network call will get a response with only variants for flags where the user is included; in v1.11, if the user is not included in the flag, a default variant is returned.

In all versions, when "variant()" is called, if the user is not included in the flag, a default variant is returned. In pre-1.11, this is "Variant(value=null, payload=null, expKey=null)", in 1.11, this is "Variant(value=null, payload=null, expKey=null, key=off, metadata={default=true})".

@tyiuhc tyiuhc closed this as completed Nov 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants