From f58b75106586e4684b2bdac0cb61622e3fe2f926 Mon Sep 17 00:00:00 2001 From: Naina Raisinghani Date: Mon, 12 Feb 2018 23:30:30 +1100 Subject: [PATCH] Remove spurious code --- extensions/amp-selector/0.1/amp-selector.js | 8 +++----- .../amp-selector/0.1/test/test-amp-selector.js | 1 - .../0.1/test/validator-amp-selector.html | 14 -------------- 3 files changed, 3 insertions(+), 20 deletions(-) diff --git a/extensions/amp-selector/0.1/amp-selector.js b/extensions/amp-selector/0.1/amp-selector.js index 18afe98e8cf91..0f09d77a38ba8 100644 --- a/extensions/amp-selector/0.1/amp-selector.js +++ b/extensions/amp-selector/0.1/amp-selector.js @@ -328,7 +328,7 @@ export class AmpSelector extends AMP.BaseElement { /** * Handles selectUp events. - * @param {!Event} event + * @param {!integer} incrementPos */ select_(incrementPos) { @@ -346,9 +346,7 @@ export class AmpSelector extends AMP.BaseElement { } const selectedOption = this.options_[selectedIndex_]; - // if (selectedOption) { - this.onOptionPicked_(selectedOption); - // } + this.onOptionPicked_(selectedOption); } /** @@ -363,7 +361,7 @@ export class AmpSelector extends AMP.BaseElement { case KeyCodes.RIGHT_ARROW: /* fallthrough */ case KeyCodes.DOWN_ARROW: if (this.kbSelectMode_ != KEYBOARD_SELECT_MODES.NONE) { - this.navigationKeyDownHandler_(event, true); + this.navigationKeyDownHandler_(event); } return; case KeyCodes.ENTER: /* fallthrough */ diff --git a/extensions/amp-selector/0.1/test/test-amp-selector.js b/extensions/amp-selector/0.1/test/test-amp-selector.js index 45b585f103660..b2997907d891e 100644 --- a/extensions/amp-selector/0.1/test/test-amp-selector.js +++ b/extensions/amp-selector/0.1/test/test-amp-selector.js @@ -876,6 +876,5 @@ describes.realWin('amp-selector', { expect(ampSelector.children[3].hasAttribute('selected')).to.be.false; }); }); - }); }); diff --git a/extensions/amp-selector/0.1/test/validator-amp-selector.html b/extensions/amp-selector/0.1/test/validator-amp-selector.html index fe404943c8854..581940c6858a7 100644 --- a/extensions/amp-selector/0.1/test/validator-amp-selector.html +++ b/extensions/amp-selector/0.1/test/validator-amp-selector.html @@ -31,20 +31,6 @@ - -
- - -
    -
    • -
    • -
  • None of the Above
    • -
- - - -
-