Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement parallax scrolling #1443

Closed
Nemo64 opened this issue Jan 15, 2016 · 12 comments
Closed

implement parallax scrolling #1443

Nemo64 opened this issue Jan 15, 2016 · 12 comments

Comments

@Nemo64
Copy link
Contributor

Nemo64 commented Jan 15, 2016

This probably doesn't fit into the performance aspect of amp. It is however an often used stylistic effect to have images parallax scrolling. This, of course, doesn't work on mobile yet and is often a problem on desktop browser too so it would be challenging. However: a correct implementation could make this effect much more pleasant.

I imagine it like this:

<amp-parallax width="1200" height="630" layout="responsive">
    <amp-img src="/image.jpg" width="1200" height="1260" layout="responsive"></amp-img>
</amp-parallax>
@cramforce
Copy link
Member

This is on our radar. It actually fits well with the performance aspect, because we want to do it well :)

CC @rudygalfi

@dvoytenko
Copy link
Contributor

Parallax can be set up via CSS and would work on Chrome fairly everywhere and on desktop Safari and Firefox.

http://jsbin.com/nevehug/edit?html,css,output

However, it won't work in iOS Safari. The main reason, I believe, is not styling itself, but the way scrolling is implemented. That would be the main challenge implementing it there as well when the scroll events arrive significantly later.

@Nemo64
Copy link
Contributor Author

Nemo64 commented Jan 15, 2016

@dvoytenko that implementation uses a div with overflow:auto around the entire page which isn't pretty and makes it invalid amp-html. I already thought about implementing paralax with css only but I found no amp valid way. That's why I opened this issue 😉

@ericlindley-g
Copy link
Contributor

Bumping up in priority, per discussion

@ericlindley-g
Copy link
Contributor

Re-opening this to track in context of using scrollbound animation framework to power the feature

@adelinamart
Copy link
Contributor

@cvializ This is a P1 that was not updated in a while. Can you provide a status here. Thank you.

@aghassemi
Copy link
Contributor

This is already shipped under an experiment flag, closing. (experiment will be launched when we are comfortable with the perf/FPS of this by aligning it with #8411 work)

@aghassemi
Copy link
Contributor

aghassemi commented Jun 8, 2017

reopening to track until experiment flag is removed and feature is fully launched.(Broken downs issues are: #7929 #7928 #7925 #7938 #7930 #7818)

@aghassemi aghassemi reopened this Jun 8, 2017
@ampprojectbot
Copy link
Member

This is a high priority issue but it hasn't been updated in awhile. @cvializ Do you have any updates?

@aghassemi aghassemi assigned aghassemi and unassigned cvializ Oct 23, 2017
@aghassemi
Copy link
Contributor

will be handled by #11746

@ampprojectbot
Copy link
Member

This is a high priority issue but it hasn't been updated in awhile. @aghassemi Do you have any updates?

@ampprojectbot
Copy link
Member

This is a high priority issue but it hasn't been updated in awhile. @aghassemi Do you have any updates?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

9 participants