Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Google AdSense for Search #2659

Closed
rudygalfi opened this issue Mar 21, 2016 · 12 comments
Closed

Support Google AdSense for Search #2659

rudygalfi opened this issue Mar 21, 2016 · 12 comments

Comments

@rudygalfi
Copy link
Contributor

Google AdSense for Search doesn't appear to be supported. This is an issue to request support

@Kadmos1 originally reported this in #1286:

I need to use on an AMP page Google Adsense For Search (AFS) ad units. Is that possible?
I've read AMP documentation and AFS ads aren't available there. I did some research but haven't found any info on this. I've also posted a question in stackoverflow but haven't received any helpful answer. http://stackoverflow.com/questions/35981279/can-i-use-google-adsense-for-search-afs-ad-units-with-amp/36024593#36024593

Can anyone help me with this?

@kashyapnitin, can you comment here?

@rudygalfi
Copy link
Contributor Author

cc @dvoytenko FYI

@ghost
Copy link

ghost commented Mar 22, 2016

Thanks @rudygalfi looking forward to see AFS support on AMP

@cramforce
Copy link
Member

This product? https://support.google.com/adsense/answer/9879?hl=en

How would that apply to AMP?

@rudygalfi rudygalfi added this to the Backlog milestone Mar 24, 2016
@megankj-zz
Copy link

I've started working on this. It will support both AFS (AdSense for Search) and AFSh (AdSense for Shopping) on the CSA (Custom Search Ads) protocol.

@jasti
Copy link
Contributor

jasti commented Aug 23, 2016

Thanks @megankj ! Assigning to you.

@jasti jasti assigned jasti and unassigned kashyapnitin Aug 23, 2016
@j1wilmot
Copy link

j1wilmot commented Nov 3, 2016

Any update on when this will be available? Thanks!

@megankj-zz
Copy link

We are targeting 11/18.

@j1wilmot
Copy link

j1wilmot commented Dec 2, 2016

Sorry to be a pest, but any update on when this will be available? I was hoping to make use of this feature before the end of the year -- I've had some issues using an iframe as a workaround. Many thanks!

@megankj-zz
Copy link

Yes, I'm really hoping to get it out by next Friday. Sorry for all the delays!

@j1wilmot
Copy link

j1wilmot commented Jan 3, 2017

@lannka I'm trying to get a sense of when this feature will be available in production. I see this got merged into master on the 21st, but it looks like it didn't make it into a release. Based on the release guidelines I think this will be available in a dev-channel release this Thursday and then hopefully deployed fully on January 12th, but I wanted to make sure this timeline is accurate. Thanks for the hard work -- looking forward to use this feature!

@megankj-zz
Copy link

Just confirmed that it should available in the dev-channel at the end of today (most likely) and fully deployed next Thursday, January 12.

@jasti
Copy link
Contributor

jasti commented Feb 2, 2017

Awesome! Closing.

@jasti jasti closed this as completed Feb 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants