Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚨 Error: Attempting to access a non-existant slide %s / %s NaN 7 #28050

Closed
ampprojectbot opened this issue Apr 27, 2020 · 6 comments · Fixed by #32695
Closed

🚨 Error: Attempting to access a non-existant slide %s / %s NaN 7 #28050

ampprojectbot opened this issue Apr 27, 2020 · 6 comments · Fixed by #32695
Assignees
Labels

Comments

@ampprojectbot
Copy link
Member

ampprojectbot commented Apr 27, 2020

Details

Error report: link
First seen: Apr 8, 2020
Frequency: ~ 61,503/day

Stacktrace

Error: Attempting to access a non-existant slide %s / %s NaN 7
    at Error (https://raw.githubusercontent.com/ampproject/amphtml/2004240001480/src/log.js:714:16)
    at createErrorVargs (https://raw.githubusercontent.com/ampproject/amphtml/2004240001480/src/log.js:308:20)
    at apply (https://raw.githubusercontent.com/ampproject/amphtml/2004240001480/src/log.js:323:18)
    at dev (https://raw.githubusercontent.com/ampproject/amphtml/2004240001480/extensions/amp-carousel/0.1/slidescroll.js:702:6)
    at showSlide_ (https://raw.githubusercontent.com/ampproject/amphtml/2004240001480/extensions/amp-carousel/0.1/slidescroll.js:758:25)
    at https://raw.githubusercontent.com/ampproject/amphtml/2004240001480/extensions/amp-carousel/0.1/slidescroll.js:603:6
    at callback (https://raw.githubusercontent.com/ampproject/amphtml/2004240001480/src/service/vsync-impl.js:470:16)
    at callTask_ (https://raw.githubusercontent.com/ampproject/amphtml/2004240001480/src/service/vsync-impl.js:426:8)

Notes

@rsimha modified src/log.js:308-311 in #21212 (May 16, 2019)
@erwinmombay modified src/log.js:323-324 in #6581 (Dec 20, 2016)
@rsimha modified extensions/amp-carousel/0.1/slidescroll.js:702-707 in #21212 (May 16, 2019)
@choumx modified extensions/amp-carousel/0.1/slidescroll.js:758-761 in #9863 (Jun 12, 2017)
@jridgewell modified src/service/vsync-impl.js:470-471 in #20836 (Feb 14, 2019)

Possible assignees: @jridgewell, @choumx

@ampprojectbot ampprojectbot added the Type: Error Report An error reported by AMP Error Reporting label Apr 27, 2020
@caroqliu
Copy link
Contributor

cc @jridgewell who made relevant changes recently and @alanorozco who is familiar with amp-carousel

@ampprojectbot
Copy link
Member Author

A duplicate error report was linked to this issue (link)

@kristoferbaxter
Copy link
Contributor

@zhouyx This error seems to be happening quite a bit.

@zhouyx
Copy link
Contributor

zhouyx commented Dec 3, 2020

if (newSlideInView === undefined) {
dev().error(
TAG,
'Attempting to access a non-existant slide %s / %s',
newIndex,
noOfSlides_
);
return false;
}

Reported here when newSlideInView is undefined, and newIndexisNaN`

@zhouyx
Copy link
Contributor

zhouyx commented Dec 3, 2020

I wonder why newIndex = dev().assertNumber(newIndex); doesn't catch the NaN

@jridgewell
Copy link
Contributor

typeof NaN === 'number'.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants