Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow variable substitution in amp-consent #28588

Closed
zhouyx opened this issue May 26, 2020 · 0 comments · Fixed by #28700
Closed

Allow variable substitution in amp-consent #28588

zhouyx opened this issue May 26, 2020 · 0 comments · Fixed by #28700
Assignees
@zhouyx
Labels
Type: Feature Request

Comments

@zhouyx
Copy link
Contributor

zhouyx commented May 26, 2020

CMP may need to keep record of user consent decision on the server side, that requires passing the userId and pageId to the consent endpoint.

Option #1: Make variable substitution a generic support feature in amp-consent, protect with an allowed list.

Option #2: Limit the support to CLIENT_ID(AMP-CONSENT), PAGE_VIEW_ID and PAGE_VIEW_ID_64.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zhouyx zhouyx

Labels
Type: Feature Request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Support variable expansion in amp-consent zhouyx/amphtml
1 participant
@zhouyx