-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New amp-ad extension needs a .md doc file #3271
Comments
Working on that. But basically no feature changed and the amp-ad docs in builtin already got updated. It seems to me adding docs to extensions/amp-ad would simply be adding a duplicate docs file there? |
This is about updating https://github.com/ampproject/amphtml/blob/master/extensions/amp-sticky-ad/amp-sticky-ad.md, right? I think we should have some content here. It should have the table that other extensions have with listings for Description, Availability, Required Script, Supported Layouts, and Examples. However, where it makes sense, it can heavily reference and make use of the documentation in amp-ad. For example, there should be a Behavior section defining how the sticky ad behaves and then it should hand off to amp-ad documentation to cover other topics. |
I believe this is about adding new amp-ad.md because it's moved to extension . |
@erwinmombay |
yes we have to do it for www.ampproject.org/docs/* since we can do redirects there |
Putting into Current milestone assuming this is getting actively worked on... |
In the refactor from a builtin to an extension, amp-ad docs got left behind. I can see rationale for that, since the lazy script loading allows publishers to treat it as a builtin. But there should be at least some docs in extensions/amp-ad.
@zhouyx ?
The text was updated successfully, but these errors were encountered: