Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[amp-story] [publisher identity] Add publisher identity in the system layer #33355

Closed
Enriqe opened this issue Mar 18, 2021 · 3 comments
Closed

[amp-story] [publisher identity] Add publisher identity in the system layer #33355

Enriqe opened this issue Mar 18, 2021 · 3 comments
Assignees
@Enriqe
Labels
Type: Feature Request WG: stories

Comments

@Enriqe
Copy link
Contributor

Enriqe commented Mar 18, 2021 •
edited
Loading

Part of #33353

On the amp-story side, check for the presence of a URL parameter and modify the system layer layout to accommodate the logo + publisher name + create link (and make sure it works correctly with RTL).

@ampproject/wg-stories
@Enriqe Enriqe self-assigned this Mar 18, 2021
@Enriqe Enriqe mentioned this issue Mar 18, 2021
Closed
@Enriqe Enriqe mentioned this issue Mar 25, 2021
Merged
@gmajoulet
Copy link
Contributor

The identity needs to be part of the initial Story render. Using a URL parameter over a viewer message sounds more appropriate.

@Enriqe
Copy link
Contributor Author

Enriqe commented Mar 25, 2021

Agreed, had planned to add that in the next PRs. Will update the original comment.

@Enriqe
Copy link
Contributor Author

Enriqe commented Apr 9, 2021

Closed by #33489

@Enriqe Enriqe closed this as completed Apr 9, 2021
@mszylkowski mszylkowski mentioned this issue Apr 12, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Enriqe Enriqe

Labels
Type: Feature Request WG: stories
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gmajoulet @Enriqe