Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Amp-ad test failure in old chrome #7917

Closed
muxin opened this issue Mar 2, 2017 · 0 comments
Closed

Amp-ad test failure in old chrome #7917

muxin opened this issue Mar 2, 2017 · 0 comments
Assignees
@muxin
Labels
P1: High Priority Type: Bug
Milestone
Sprint H1 March

Comments

@muxin
Copy link
Contributor

muxin commented Mar 2, 2017 

Chrome 45.0.2454 (Linux 0.0.0) Ad loader amp-ad falls back to Delayed Fetch if remote.html is used FAILED
	TypeError: doc.head.append is not a function
	    at /tmp/2f06726ddd8d00d626276bbae795cee0.browserify:31169:20 <- /home/travis/build/ampproject/amphtml/extensions/amp-ad/0.1/test/test-amp-ad.js:143:19
.......
Chrome 45.0.2454 (Linux 0.0.0) Ad loader amp-embed falls back to Delayed Fetch if remote.html is used FAILED
	TypeError: doc.head.append is not a function
	    at /tmp/2f06726ddd8d00d626276bbae795cee0.browserify:31169:20 <- /home/travis/build/ampproject/amphtml/extensions/amp-ad/0.1/test/test-amp-ad.js:143:19

From #7906
@muxin muxin self-assigned this Mar 2, 2017
@muxin muxin added this to the Sprint H1 March milestone Mar 2, 2017
@muxin muxin mentioned this issue Mar 2, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@muxin muxin

Labels
P1: High Priority Type: Bug
Projects
None yet
Milestone
Sprint H1 March
Development

No branches or pull requests
1 participant
@muxin