Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ITI: read position progress bar #8658

Closed
bjalford opened this issue Apr 10, 2017 · 7 comments
Closed

ITI: read position progress bar #8658

bjalford opened this issue Apr 10, 2017 · 7 comments
Assignees
Labels
INTENT TO IMPLEMENT Proposes implementation of a significant new feature. https://bit.ly/amp-contribute-code P3: When Possible Type: Feature Request
Milestone

Comments

@bjalford
Copy link

Would like to implement a scroll bar to to indicate read position of AMP document.

Similar to this kind of thing: http://www.cssscript.com/demo/tiny-reading-progress-indicator-pure-javascript-rpbar-js/

Would anyone else find this useful? Any feedback before we start looking into coding?

@bjalford bjalford changed the title ITP: read position progress bar ITI: read position progress bar Apr 10, 2017
@aghassemi aghassemi added INTENT TO IMPLEMENT Proposes implementation of a significant new feature. https://bit.ly/amp-contribute-code Category: Presentation Type: Feature Request labels Apr 10, 2017
@aghassemi aghassemi added this to the New FRs milestone Apr 10, 2017
@aghassemi
Copy link
Contributor

@bjalford I think this UI will be useful in general. Instead of a dedicated component however, we could add support for such scroll-bound effect to #8411.

Currently #8411's design assumes one viewport scroll as duration of an effect, simply allowing users to pick "1 page scroll" instead of "1 viewport scroll" as duration can enable this and more.

#8411 is currently in progress, I recommend waiting until enough of scroll-bound animation work is in place and then evaluating whether this makes sense as a separate component or extending scroll-bound animation to support "1 page scroll" instead.

@bjalford
Copy link
Author

Thanks. Makes sense.

@niutech
Copy link
Contributor

niutech commented Mar 29, 2018

Another solution is to use a pure CSS scroll depth indicator.

@mrjoro
Copy link
Member

mrjoro commented Jan 15, 2019

Is this I2I still active?

@tobiasfrenkler
Copy link

Very useful feature, especially for longer articles. I would love to see it implemented. Is it still under consideration?

@aghassemi
Copy link
Contributor

@tobiasfrenkler a component for this is not prioritized but this is doable in AMP using amp-position-observer, here is an example: https://codepen.io/aghassemi/pen/MxQxZR?editors=1111

@aghassemi
Copy link
Contributor

deduping with same request on #19193

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
INTENT TO IMPLEMENT Proposes implementation of a significant new feature. https://bit.ly/amp-contribute-code P3: When Possible Type: Feature Request
Projects
None yet
Development

No branches or pull requests

6 participants