Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚨 Error: AbortController is not defined #15

Closed
ampprojectbot opened this issue Oct 12, 2020 · 3 comments
Closed

🚨 Error: AbortController is not defined #15

ampprojectbot opened this issue Oct 12, 2020 · 3 comments

Comments

@ampprojectbot
Copy link
Member

Details

Error report: link
First seen: Oct 10, 2020
Frequency: ~ 6,431/day

Stacktrace

Error: AbortController is not defined
    at AbortController (src/service/resource.js:942:32)
    at task (src/service/resources-impl.js:1522:25)
    at callback (src/finite-state-machine.js:72:6)
    at setState (src/service/resources-impl.js:777:4)
    at doPass (src/service/resources-impl.js:136:42)
    at handler_ (src/pass.js:109:4)
    at pass_ (src/pass.js:55:6)
    at callback (src/service/timer-impl.js:76:10)

Notes

@jridgewell modified src/finite-state-machine.js:63-78 in #1637 (Mar 18, 2016)
@dvoytenko modified src/service/resources-impl.js:777-777 in #24566 (Sep 20, 2019)
@jridgewell modified src/service/resources-impl.js:136-136 in #9789 (Jun 8, 2017)
@jridgewell modified src/pass.js:105-112 in #3513 (Jun 9, 2016)
@rsimha modified src/pass.js:50-56 in #23559 (Jul 29, 2019)
@rsimha modified src/service/timer-impl.js:70-78 in #21212 (May 16, 2019)

Seen in:

  • 10-10 Nightly (0157)

Possible assignees: @jridgewell

/cc @ampproject/release-on-duty

@rcebulko
Copy link
Collaborator

/cc @jridgewell @erwinmombay 100% of these occurrences are in ESM

@rcebulko
Copy link
Collaborator

Seems very likely to have been caused by ampproject/amphtml#30426 , which introduced the AbortController constructor but appears to not actually import it in resources.js.

@jridgewell
Copy link

Closed by ampproject/amphtml#30624, and we're doing a nightly cherry-pick to resolve it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants