fix: Set Tableau URLs (base + API) via config #349
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
When executing the Tableau extractor in different environments (development, production, etc), we saw the need to have different URLs and protocols depending on connectivity. For example, our airflow server that runs the extractor routes to the Tableau server via port 80 and a specific IP address.
To allow for the most configurability, this PR opens up 2 values:
API_BASE_URL
- Protocol+Host for API callsTABLEAU_BASE_URL
- Protocol+Host for links on the Dashboard Detail page (eg. "Open Dashboard" button)TABLEAU_HOST
has been removed in favor of these.Tests
Added new configs to tests.
Documentation
CheckList
Make sure you have checked all steps below to ensure a timely review.
make test