feat: Mode Batch dashboard chart extractor using discovery API #362
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: feng-tao [email protected]
Summary of Changes
Leverage the latest mode discovery API(https://mode.com/help/articles/discovery-api/) which is much more performant than the previous version. Feel free to check out mode's blog post(https://mode.com/blog/new-features-to-help-you-manage-users-and-discover-data-at-scale/)
Previous mode chart legacy API doesn't work as it doesn't return the full data.
Tests
yes with Lyft staging as well
Documentation
yes
CheckList
Make sure you have checked all steps below to ensure a timely review.
make test