Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package not activating automatically #6

Open
mradzinski opened this issue Nov 27, 2015 · 4 comments
Open

Package not activating automatically #6

mradzinski opened this issue Nov 27, 2015 · 4 comments

Comments

@mradzinski
Copy link

On the latest stable Atom version to date (1.2.4) The following lines are preventing the package to auto-activate itself upon start.

unless atom.project.getRepositories().length
    @disp.setDisposable rx.Disposable.empty
    return

Removing/Commenting those lines fixes the issue.

@anaisbetts
Copy link
Owner

This is by-desgn, this code stops the package from loading if the project isn't backed by a Git repo, since saving automatically might actually result in users losing data

@mradzinski
Copy link
Author

Well, actually the project I tried was a Git repo. I think there might be somehow of a racing condition. I tried debugging that part of the code through console logs and sometimes I see the project is recognised as a Git one and sometimes it's not.

@anaisbetts
Copy link
Owner

Oh, in that case that's deffo a bug, wonder if this is an ordering issue in package activation

@mradzinski
Copy link
Author

Yep, I do think it's an ordering issue. I'll try get more proof and in such case I'll report it on the Atom repo since this kind of issues should be handled by them (I don't think you are able to control the packaging activation order).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants