-
-
Notifications
You must be signed in to change notification settings - Fork 251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(vite-plugin-nitro): add internal deployment support for cloudflare #1020
Conversation
✅ Deploy Preview for analog-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for analog-app ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for analog-blog ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for analog-ng-app ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
5fa86aa
to
39cb33b
Compare
Hi @brandonroberts 🙂 👋 Any chance you could try to integrate nitro-cloudflare-dev as well here? 😃 🙏 |
@dario-piotrowicz could be doable based on the example @jculvey put together. |
@brandonroberts yeah 🙂 But james' version requires some code in userland, it's not terrible and I'm fine with it, but if we could actually leverage Not a huge deal 🙂 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for these updates, @brandonroberts! I left a few comments.
// cc @jculvey @dario-piotrowicz
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
Which package are you modifying?
What is the current behavior?
Extra plugin configuration is needed to deploy to Cloudflare Pages
Closes #
What is the new behavior?
No extra plugin configuration is needed to deploy to Cloudflare Pages
Does this PR introduce a breaking change?
Other information
[optional] What gif best describes this PR or how it makes you feel?