Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(vite-plugin-nitro): add internal deployment support for cloudflare #1020

Merged
merged 5 commits into from
Apr 11, 2024

Conversation

brandonroberts
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

Which package are you modifying?

  • vite-plugin-angular
  • vite-plugin-nitro
  • astro-angular
  • create-analog
  • router
  • platform
  • content
  • nx-plugin
  • trpc

What is the current behavior?

Extra plugin configuration is needed to deploy to Cloudflare Pages

Closes #

What is the new behavior?

No extra plugin configuration is needed to deploy to Cloudflare Pages

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

[optional] What gif best describes this PR or how it makes you feel?

Copy link

netlify bot commented Apr 10, 2024

Deploy Preview for analog-docs ready!

Name Link
🔨 Latest commit fe16707
🔍 Latest deploy log https://app.netlify.com/sites/analog-docs/deploys/66174dffec431f00085e53ce
😎 Deploy Preview https://deploy-preview-1020--analog-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Apr 10, 2024

Deploy Preview for analog-app ready!

Name Link
🔨 Latest commit fe16707
🔍 Latest deploy log https://app.netlify.com/sites/analog-app/deploys/66174dffc3976d0009a7f83c
😎 Deploy Preview https://deploy-preview-1020--analog-app.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Apr 10, 2024

Deploy Preview for analog-blog ready!

Name Link
🔨 Latest commit fe16707
🔍 Latest deploy log https://app.netlify.com/sites/analog-blog/deploys/66174dff5c09c80008cdbc2b
😎 Deploy Preview https://deploy-preview-1020--analog-blog.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Apr 10, 2024

Deploy Preview for analog-ng-app ready!

Name Link
🔨 Latest commit fe16707
🔍 Latest deploy log https://app.netlify.com/sites/analog-ng-app/deploys/66174dffe9498e0008a84153
😎 Deploy Preview https://deploy-preview-1020--analog-ng-app.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

cloudflare-workers-and-pages bot commented Apr 10, 2024

Deploying analog-app with  Cloudflare Pages  Cloudflare Pages

Latest commit: 39cb33b
Status:⚡️  Build in progress...

View logs

@dario-piotrowicz
Copy link

Hi @brandonroberts 🙂 👋

Any chance you could try to integrate nitro-cloudflare-dev as well here? 😃 🙏

@brandonroberts
Copy link
Member Author

Hi @brandonroberts 🙂 👋

Any chance you could try to integrate nitro-cloudflare-dev as well here? 😃 🙏

@dario-piotrowicz could be doable based on the example @jculvey put together.

https://github.com/jculvey/c3-analog-example

@dario-piotrowicz
Copy link

@brandonroberts yeah 🙂

But james' version requires some code in userland, it's not terrible and I'm fine with it, but if we could actually leverage nitro-cloudflare-dev instead that's be nicer

Not a huge deal 🙂

Copy link

@IgorMinar IgorMinar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for these updates, @brandonroberts! I left a few comments.

// cc @jculvey @dario-piotrowicz

apps/docs-app/docs/features/deployment/providers.md Outdated Show resolved Hide resolved
apps/analog-app/src/main-cf.server.ts Show resolved Hide resolved
apps/docs-app/docs/features/deployment/providers.md Outdated Show resolved Hide resolved
@brandonroberts brandonroberts merged commit 56ee19d into beta Apr 11, 2024
24 checks passed
@brandonroberts brandonroberts deleted the feat-cloudlare-deploy branch April 11, 2024 03:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants