Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(vite-plugin-angular): improve support for Angular Material and testing using harnesses #1442

Merged
merged 3 commits into from
Nov 14, 2024

Conversation

brandonroberts
Copy link
Member

PR Checklist

Closes #1440

What is the new behavior?

Angular Material and using Material Harnesses for testing is supported without additional vite configuration.

  • The @angular/material package wasn't being transformed when only using the @analogjs/vite-plugin-angular package.
  • The @angular/cdk/testing/testbed package as not being properly optimized for testing with zone.js
  • Also fixed a bug where inline styles were being processed by the internal sourcemap plugin.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

[optional] What gif best describes this PR or how it makes you feel?

Copy link

netlify bot commented Nov 14, 2024

Deploy Preview for analog-docs ready!

Name Link
🔨 Latest commit 839a699
🔍 Latest deploy log https://app.netlify.com/sites/analog-docs/deploys/6736486c5aa4b6000836b1f0
😎 Deploy Preview https://deploy-preview-1442--analog-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Nov 14, 2024

Deploy Preview for analog-blog ready!

Name Link
🔨 Latest commit 839a699
🔍 Latest deploy log https://app.netlify.com/sites/analog-blog/deploys/6736486d65fc90000877c61f
😎 Deploy Preview https://deploy-preview-1442--analog-blog.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Nov 14, 2024

Deploy Preview for analog-app ready!

Name Link
🔨 Latest commit 839a699
🔍 Latest deploy log https://app.netlify.com/sites/analog-app/deploys/6736486ccdae700008c2ea19
😎 Deploy Preview https://deploy-preview-1442--analog-app.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Nov 14, 2024

Deploy Preview for analog-ng-app ready!

Name Link
🔨 Latest commit 839a699
🔍 Latest deploy log https://app.netlify.com/sites/analog-ng-app/deploys/6736486c3e98c50008e123e8
😎 Deploy Preview https://deploy-preview-1442--analog-ng-app.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@brandonroberts brandonroberts merged commit 8338d42 into beta Nov 14, 2024
23 of 24 checks passed
@brandonroberts brandonroberts deleted the fix-vitest-material-testing branch November 14, 2024 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Angular Vitest isn't working with Material Harnesses
1 participant