Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use VirtualPath to build Dependencies section #2990

Closed
merlin-uk opened this issue Jun 25, 2024 · 2 comments
Closed

Use VirtualPath to build Dependencies section #2990

merlin-uk opened this issue Jun 25, 2024 · 2 comments
Labels
changelog-ignore Don't include this issue in the release changelog enhancement New feature or request

Comments

@merlin-uk
Copy link

What would you like to be added:
We would like the Dependencies section to be added to the bottom of the SBOM.
Why is this needed:
SBOMs need to have a Dependencies section to be valid.
Additional context;
The VirtualPath which is created under each Property section can be used to build a Dependencies section.

@merlin-uk merlin-uk added the enhancement New feature or request label Jun 25, 2024
@kzantow
Copy link
Contributor

kzantow commented Jun 25, 2024

Hi @merlin-uk -- could you expand on this request? I don't think we could build a dependency tree strictly based on file paths. Are you referring to Java, specifically? If so, I don't think we can use the JAR nesting to build a dependency graph, either, necessarily. We could probably use this to make CONTAINS relationships, but I don't believe this would accomplish what you are asking for, as this is different than a dependency relationship, and would not show up in CycloneDX dependencies. We would definitely need a bit more information to understand exactly what the use case you are trying to solve is here, if you could expand on this some.

@kzantow
Copy link
Contributor

kzantow commented Oct 23, 2024

Hi @merlin-uk -- a feature was just implemented that includes some amount of dependency information for Java. One of the things that this change surfaces is dependencies for nested Java archives, for example: a .war file which contains .jar files, the containing WAR file will have dependency relationships to the contained JAR files. I think this will accomplish what this issue is asking for, so I'm going to close this issue. If I've misunderstood or there are cases that the current implementation doesn't account for, please let us know and we can reopen this!

@kzantow kzantow closed this as completed Oct 23, 2024
@willmurphyscode willmurphyscode added the changelog-ignore Don't include this issue in the release changelog label Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog-ignore Don't include this issue in the release changelog enhancement New feature or request
Projects
Status: Done
Development

No branches or pull requests

4 participants