Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unconditional recursive call at spyReturningFileResolver.Read #3379

Closed
chavacava opened this issue Oct 24, 2024 · 0 comments · Fixed by #3392
Closed

Unconditional recursive call at spyReturningFileResolver.Read #3379

chavacava opened this issue Oct 24, 2024 · 0 comments · Fixed by #3392
Assignees
@kzantow
Labels
changelog-ignore Don't include this issue in the release changelog

Comments

@chavacava
Copy link
Contributor

The following code will recurse "infinitely"

syft/syft/pkg/cataloger/generic/cataloger_test.go

Lines 110 to 112 in 759b898

func (s *spyingIoReadCloser) Read(p []byte) (n int, err error) {
return s.Read(p)
}

Found by revive
@kzantow kzantow mentioned this issue Oct 29, 2024
Merged
3 tasks
@kzantow kzantow self-assigned this Oct 29, 2024
@kzantow kzantow added the changelog-ignore Don't include this issue in the release changelog label Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kzantow kzantow

Labels
changelog-ignore Don't include this issue in the release changelog
Projects
OSS
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: stack overflow in spyingIoReadCloser kzantow-anchore/syft
2 participants
@kzantow @chavacava