Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

夜間航空攻撃で空母夜襲CIの条件を満たさない場合に攻撃力の計算式が誤っている #261

Open
grdanjou opened this issue Jul 7, 2019 · 0 comments

Comments

@grdanjou
Copy link
Contributor

grdanjou commented Jul 7, 2019

夜間航空攻撃(Graf、Ark Royal、未改造Saratoga、大鷹などの夜間空撃は除く)の条件を満たし、かつ空母夜襲CIの条件を満たさない場合に攻撃力の計算式が火力+雷装になってしまう。

修正イメージ:

--- a/ElectronicObserver/Data/ShipData.cs
+++ b/ElectronicObserver/Data/ShipData.cs
@@ -1192,7 +1192,7 @@ namespace ElectronicObserver.Data
             var kind = Calculator.GetNightAttackKind(AllSlotMaster.ToArray(), ShipID, -1);
             double basepower = 0;

-            if (kind == NightAttackKind.CutinAirAttack)
+            if (kind == NightAttackKind.CutinAirAttack || (kind == NightAttackKind.AirAttack && is夜間航空攻撃の計算式))
             {

NightAttackKind.AirAttackに夜間航空攻撃の計算式を使用しない空撃が複数パターン含まれており、コードの修正(移植)量が多くなるため、プルリクエストを出すのは避けました。お手数ですが確認をお願いします。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant